Draft: Fix Vendoring#496
Closed
dtfranz wants to merge 1 commit into
Closed
Conversation
Signed-off-by: dtfranz <dfranz@redhat.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
/test all |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dtfranz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
@dtfranz: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-bot
pushed a commit
to openshift-bot/operator-framework-olm
that referenced
this pull request
Jun 6, 2026
…les (openshift#496) * fix: stop emitting false-positive deprecated-API warnings for RBAC rules RBAC PolicyRules only specify apiGroups and resources, not versions. The deprecatedGroupResource map was flagging any RBAC rule that referenced a group+resource combination where a beta version had been removed, even when a stable version still exists in the same group. This produced false-positive warnings for operators that use stable APIs like batch/v1 CronJob, autoscaling/v2 HPA, events.k8s.io/v1 Event, policy/v1 PDB, discovery.k8s.io/v1 EndpointSlice, and node.k8s.io/v1 RuntimeClass. Remove these entries from the deprecatedGroupResource map since RBAC rules for them are valid. Keep only PodSecurityPolicy, which was entirely removed in v1.25 with no stable replacement in the policy group. The deprecatedGvk check (for actual versioned manifests in the bundle) is unaffected and continues to correctly flag deprecated objects. Fixes openshift#378 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca> * refactor: rename deprecatedGroupResource to removedGroupResource Rename identifiers to match actual semantics: this map tracks resources entirely removed from their API group, not merely deprecated. Renames deprecatedGroupResource -> removedGroupResource and warnIfDeprecated -> warnIfRemoved. Suggested-by: Copilot Requested-by: perdasilva Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca> --------- Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca> Upstream-repository: api Upstream-commit: 86d7cedb27dc0ec9a67903e4cf6ea18b31c80562
openshift-bot
pushed a commit
to openshift-bot/operator-framework-olm
that referenced
this pull request
Jun 9, 2026
…les (openshift#496) * fix: stop emitting false-positive deprecated-API warnings for RBAC rules RBAC PolicyRules only specify apiGroups and resources, not versions. The deprecatedGroupResource map was flagging any RBAC rule that referenced a group+resource combination where a beta version had been removed, even when a stable version still exists in the same group. This produced false-positive warnings for operators that use stable APIs like batch/v1 CronJob, autoscaling/v2 HPA, events.k8s.io/v1 Event, policy/v1 PDB, discovery.k8s.io/v1 EndpointSlice, and node.k8s.io/v1 RuntimeClass. Remove these entries from the deprecatedGroupResource map since RBAC rules for them are valid. Keep only PodSecurityPolicy, which was entirely removed in v1.25 with no stable replacement in the policy group. The deprecatedGvk check (for actual versioned manifests in the bundle) is unaffected and continues to correctly flag deprecated objects. Fixes openshift#378 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca> * refactor: rename deprecatedGroupResource to removedGroupResource Rename identifiers to match actual semantics: this map tracks resources entirely removed from their API group, not merely deprecated. Renames deprecatedGroupResource -> removedGroupResource and warnIfDeprecated -> warnIfRemoved. Suggested-by: Copilot Requested-by: perdasilva Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca> --------- Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca> Upstream-repository: api Upstream-commit: 86d7cedb27dc0ec9a67903e4cf6ea18b31c80562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
make verifyci has been failing, this is an attempt to fix it.