Bug 1942522: Fix resolution error if inner entry doesn't provide a required API. #60

benluddy · 2021-04-19T20:27:03Z

For bundle-to-bundle dependencies (as opposed to
subscription-to-bundle "dependencies"), candidates were filtered first
to only those that satisfy the constraint in question, then sorted in
channel order. Since the relative order of entries within a channel is
currently determined by replaces-distance from the channel head,
sorting would fail if an entry in the middle of a channel's replaces
chain did not satisfy the constraint.

For example, assume an operator "bar" has three available versions
within a single channel: bar-1, bar-2, and bar-3. If bar-1 and bar-3
provide the API "Bar", but bar-2 does not, then resolution will fail
for any operator that requires the API "Bar", because bar-1 and bar-3
are not connected by update edges without bar-2.

Now, all (package, channel, catalog) combinations satisfying a
constraint are enumerated and sorted before filtering to only those
entries that satisfy the constraint.

For bundle-to-bundle dependencies (as opposed to subscription-to-bundle "dependencies"), candidates were filtered first to only those that satisfy the constraint in question, then sorted in channel order. Since the relative order of entries within a channel is currently determined by replaces-distance from the channel head, sorting would fail if an entry in the middle of a channel's replaces chain did not satisfy the constraint. For example, assume an operator "bar" has three available versions within a single channel: bar-1, bar-2, and bar-3. If bar-1 and bar-3 provide the API "Bar", but bar-2 does not, then resolution will fail for any operator that requires the API "Bar", because bar-1 and bar-3 are not connected by update edges without bar-2. Now, all (package, channel, catalog) combinations satisfying a constraint are enumerated and sorted before filtering to only those entries that satisfy the constraint. Upstream-commit: f40e8e5a92f216aa5b84e7d7097b5221b925e43b Upstream-repository: operator-lifecycle-manager

openshift-ci-robot · 2021-04-19T20:27:10Z

@benluddy: This pull request references Bugzilla bug 1942522, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 1942522: Fix resolution error if inner entry doesn't provide a required API.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu

/lgtm

openshift-ci-robot · 2021-04-19T20:29:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [benluddy,dinhxuanvu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-04-19T22:48:23Z

/retest