UPSTREAM: <carry>: Add tests-extension verify to openshift verify

Signed-off-by: Todd Short <todd.short@me.com>

Author: tmshort

openshift/Makefile

@@ -21,6 +21,7 @@ export GO_BUILD_LDFLAGS := -s -w -X '$(VERSION_PATH).gitCommit=$(GIT_COMMIT)'
 verify: ## Run downstream-specific verify
 	$(MAKE) tidy fmt generate -C $(DIR)/../
 	$(MAKE) manifests
+	$(MAKE) -C tests-extension verify
 	git diff --exit-code
 
 .PHONY: manifests

openshift/tests-extension/Makefile

@@ -42,7 +42,7 @@ TOOLS_BIN_DIR := $(CURDIR)/bin
 
 #SECTION Development
 .PHONY: verify #HELP To verify the code
-verify: tidy fmt vet lint
+verify: bindata verify-metadata tidy fmt vet lint
 
 .PHONY: tidy #HELP Run go mod tidy.
 tidy:
@@ -89,7 +89,7 @@ build: bindata #HELP Build the extended tests binary
 	GO_COMPLIANCE_POLICY="exempt_all" go build -ldflags "$(LDFLAGS)" -mod=vendor -o $(TOOLS_BIN_DIR)/olmv1-tests-ext ./cmd/...
 
 .PHONY: update-metadata
-update-metadata: #HELP Build and run 'update-metadata' to generate test metadata
+update-metadata: build #HELP Build and run 'update-metadata' to generate test metadata
 	$(TOOLS_BIN_DIR)/olmv1-tests-ext update --component openshift:payload:olmv1
 	$(MAKE) clean-metadata
 
@@ -144,7 +144,7 @@ clean-metadata: #HELP Remove 'codeLocations' from metadata JSON
 
 .PHONY: verify-metadata #HELP To verify that the metadata was properly update
 verify-metadata: update-metadata
-	@if ! git diff --exit-code $(METADATA); then \
+	@if ! git diff --exit-code >&/dev/null; then \
 		echo "ERROR: Metadata is out of date. Please run 'make build-update' and commit the result."; \
 		exit 1; \
 	fi