-
Notifications
You must be signed in to change notification settings - Fork 36
[release-4.15] OCPBUGS-37549: Set required-scc for openshift workloads #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.15] OCPBUGS-37549: Set required-scc for openshift workloads #120
Conversation
|
@kramaranya: This pull request references Jira Issue OCPBUGS-37549, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@kramaranya: This pull request references Jira Issue OCPBUGS-37549, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kramaranya: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, kevinrizza, kramaranya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label cherry-pick-approved |
|
@kramaranya: Jira Issue OCPBUGS-37549: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-37549 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-olm-operator-controller |
OCPBUGS-37549
Cherry-pick of #100
Description of the change:
This PR explicitly sets the required SCC to be used to admit pods of the
operator-controller-controller-managerdeployment. The SCC chosen is the one that the pods are already getting admitted with, which means that this brings no change to the SCC used.Motivation for the change:
In some cases, custom SCCs can have higher priority than default SCCs, which means that they will be chosen over the default ones. This can lead to unexpected results; in order to protect openshift workloads from this, we must explicitly pin the required SCC to all our workloads in order to make sure that the expected one will be used.