-
Notifications
You must be signed in to change notification settings - Fork 36
OPRUN-4252: fix(OTE): fix OpenShift Kubernetes replace version format #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPRUN-4252: fix(OTE): fix OpenShift Kubernetes replace version format #549
Conversation
|
@camilamacedo86: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f8bf45e to
2794f19
Compare
2794f19 to
ac5e094
Compare
|
Can you update the PR description? |
cee1453 to
ec0a4ae
Compare
|
@camilamacedo86: This pull request references OPRUN-4252 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Using the same JIRA of: OPRUN-4252 / #544 |
|
@camilamacedo86: This pull request references OPRUN-4252 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ec0a4ae to
d5bfe85
Compare
|
@camilamacedo86: This pull request references OPRUN-4252 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
… format Fix k8s.io/kubernetes replace version from v1.30.1-0... to v0.0.0-... format to resolve bumper tool verification failures. Add hack/ocp-replace.sh script to manage OCP fork replaces properly. Assisted-by: Cursor
d5bfe85 to
9498b0a
Compare
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @kuiwang02 |
|
@kuiwang02: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
53fe424
into
openshift:main
Problem
After merging #544, the operator-framework-tooling bumper started failing when attempting to verify the synthetic versions of
github.com/openshift/kubernetesmodules. The bumper encounters the following errors:github.com/openshift/kubernetes@v1.30.1-0.20251108023427-891f5bb03061does not exist in the Go module proxysum.golang.org, the service returns a 500 errorThese errors occur because:
sum.golang.org) cannot verify these private fork modulesgo mod tidyandgo mod vendorwithout special environment variables (GOPRIVATE/GONOSUMDB), causing verification failuresSolution
Fix the version format issue and add a helper script to properly manage OpenShift Kubernetes fork replaces. The key changes:
k8s.io/kubernetesreplace fromv1.30.1-0.20251108023427-891f5bb03061tov0.0.0-20251108023427-891f5bb03061to use the correct pseudo-version format that works with the Go module systemhack/ocp-replace.shto properly construct and update OpenShift Kubernetes fork replaces, handling the module path mismatch betweenk8s.io/kubernetesandgithub.com/openshift/kubernetesGOPRIVATEandGONOSUMDBinternally during version resolution, but producesgo.mod/go.sumfiles that work without those environment variables, making it compatible with the downstreaming processgo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpcreplace directive (no longer needed)Tests