Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.11] Bug 1554293 - logging-eventrouter event not formatted correctly in El… #1374

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #1357

/assign nhosoi

…asticsearch when using MUX

When fluentd is configured as a collector and MUX, event logs from the event
router need to be processed by MUX not by the collector fluentd for the both
MUX_CLIENT_MODE=maximal and minimal cases.  It is because if an event log is
formatted in the collector (note: the event record is put under the kubernetes
key), the log is forwarded to MUX and passed to the k8s-meta plugin and the
existing kubernetes record is overwritten.

To avoid the replacement, if the log is from event router, the tag is rewritten
to ${tag}.raw in input-post-forward-mux.conf, which makes the log treated in
the MUX_CLIENT_MODE=minimal way.

There was another bug in ansible.  That is, the environment variable TRANSFORM_
EVENTS was not set in MUX even if openshift_logging_install_eventrouter is set
to true.  This PR fixes the issue.
openshift/openshift-ansible#10207

In Fluentd run.sh, "process_kubernetes_events false" is set in the filter-viaq-
data-model plugin to suppress processing the event logs.  It is _not_ set, i.e.,
event router log processing is enabled, when TRANSFORM_EVENTS is true and the
fluentd is standalone (no MUX configured) or the fluentd is MUX.

Correct the order of shutdown fluentd, reset MUX_CLIENT_MODE, then restart.
@nhosoi
Copy link
Contributor

nhosoi commented Oct 4, 2018

/retest

1 similar comment
@nhosoi
Copy link
Contributor

nhosoi commented Oct 6, 2018

/retest

@nhosoi
Copy link
Contributor

nhosoi commented Oct 6, 2018

The logging and json-file tests are failing since the ansible pr/10242 failed by the test flakes.
openshift/openshift-ansible#10242

@jcantrill
Copy link
Contributor

/retest

@jcantrill
Copy link
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2018
@jcantrill
Copy link
Contributor

/retest json-file

@richm
Copy link
Contributor

richm commented Oct 8, 2018

/retest

4 similar comments
@richm
Copy link
Contributor

richm commented Oct 9, 2018

/retest

@richm
Copy link
Contributor

richm commented Oct 10, 2018

/retest

@nhosoi
Copy link
Contributor

nhosoi commented Oct 10, 2018

/retest

@nhosoi
Copy link
Contributor

nhosoi commented Oct 11, 2018

/retest

@nhosoi
Copy link
Contributor

nhosoi commented Oct 11, 2018

/test logging

1 similar comment
@nhosoi
Copy link
Contributor

nhosoi commented Oct 11, 2018

/test logging

@nhosoi
Copy link
Contributor

nhosoi commented Oct 12, 2018

openshift/openshift-ansible#10242 was finally merged!

/retest

@richm richm removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2018
@richm
Copy link
Contributor

richm commented Oct 12, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2018
@richm
Copy link
Contributor

richm commented Oct 12, 2018

/retest

2 similar comments
@richm
Copy link
Contributor

richm commented Oct 13, 2018

/retest

@richm
Copy link
Contributor

richm commented Oct 13, 2018

/retest

@nhosoi
Copy link
Contributor

nhosoi commented Oct 14, 2018

/test json-file

@richm
Copy link
Contributor

richm commented Oct 14, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit f15b5f5 into openshift:release-3.11 Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. release/3.11 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants