New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.11] Bug 1554293 - logging-eventrouter event not formatted correctly in El… #1374
Merged
openshift-merge-robot
merged 1 commit into
openshift:release-3.11
from
openshift-cherrypick-robot:cherry-pick-1357-to-release-3.11
Oct 14, 2018
Merged
[release-3.11] Bug 1554293 - logging-eventrouter event not formatted correctly in El… #1374
openshift-merge-robot
merged 1 commit into
openshift:release-3.11
from
openshift-cherrypick-robot:cherry-pick-1357-to-release-3.11
Oct 14, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asticsearch when using MUX
When fluentd is configured as a collector and MUX, event logs from the event
router need to be processed by MUX not by the collector fluentd for the both
MUX_CLIENT_MODE=maximal and minimal cases. It is because if an event log is
formatted in the collector (note: the event record is put under the kubernetes
key), the log is forwarded to MUX and passed to the k8s-meta plugin and the
existing kubernetes record is overwritten.
To avoid the replacement, if the log is from event router, the tag is rewritten
to ${tag}.raw in input-post-forward-mux.conf, which makes the log treated in
the MUX_CLIENT_MODE=minimal way.
There was another bug in ansible. That is, the environment variable TRANSFORM_
EVENTS was not set in MUX even if openshift_logging_install_eventrouter is set
to true. This PR fixes the issue.
openshift/openshift-ansible#10207
In Fluentd run.sh, "process_kubernetes_events false" is set in the filter-viaq-
data-model plugin to suppress processing the event logs. It is _not_ set, i.e.,
event router log processing is enabled, when TRANSFORM_EVENTS is true and the
fluentd is standalone (no MUX configured) or the fluentd is MUX.
Correct the order of shutdown fluentd, reset MUX_CLIENT_MODE, then restart.
|
/retest |
1 similar comment
|
/retest |
|
The logging and json-file tests are failing since the ansible pr/10242 failed by the test flakes. |
|
/retest |
|
/hold |
|
/retest json-file |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/test logging |
1 similar comment
|
/test logging |
|
openshift/openshift-ansible#10242 was finally merged! /retest |
|
/lgtm |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test json-file |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm
Indicates that a PR is ready to be merged.
release/3.11
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1357
/assign nhosoi