[release-3.8] bug 1524644. Curator configuration produces wrong regular expressions #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example `^.operations.` instead of `^\.operations\..*$` Both regexes match, but the first one only accidentaly. Example index name: `.operations.1827ac8a-ef8f-11e7-92de-0ebdd5807cb2.2018.01.02` Curator code: https://github.com/elastic/curator/blob/3.5/curator/api/filter.py#L90-L138
openshift-ci-robot
added
the
size/S
|
/lgtm |
|
/test logging |
2 similar comments
|
/test logging |
|
/test logging |
|
/test logging |
|
/test logging |
|
well, this is a hard error - I'm not sure what's going on here, why this curator fix causes failures in other tests, but it needs to be fixed, or this PR is not going to be merged |
|
/test logging |
|
/retest |
1 similar comment
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #876
/assign richm