New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix .kibana regex
#958
Fix .kibana regex
#958
Conversation
|
/cherrypick release-3.7 |
|
@josefkarasek: once the present PR merges, I will cherry-pick it on top of release-3.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-3.8 |
|
@josefkarasek: once the present PR merges, I will cherry-pick it on top of release-3.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
curator/src/curator_cmd.py
Outdated
| @@ -95,7 +95,7 @@ def default_index(self): | |||
| + ' --older-than ' + str(count) \ | |||
| + ' --time-unit ' + unit \ | |||
| + ' --exclude ' + shellquote('^' + re.escape('.searchguard.') + '.*$') \ | |||
| + ' --exclude ' + shellquote('^' + re.escape('.kibana.') + '.*$') | |||
| + ' --exclude ' + shellquote('^' + re.escape('.kibana') + '$') | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually... there can be any number of kibana indexes depending on the mode so it should really be '.kibana.*'
54dee4f
to
6ad5e3e
Compare
|
@richm @jcantrill what do you think now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
@josefkarasek: new pull request created: #963 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@josefkarasek: #958 failed to apply on top of branch "release-3.8": |
…58-to-release-3.7 Automatic merge from submit-queue. [release-3.7] Fix `.kibana` regex This is an automated cherry-pick of #958 /assign josefkarasek
|
/cherrypick release-3.6 |
|
@richm: #958 failed to apply on top of branch "release-3.6": |
backport of openshift#958
I was trying to fix
' --exclude .searchguard* --exclude .kibana*'and did not realize that the kibana index is named just.kibanaand the regex.kibana*worked only by accident.