Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default value if the STARTUP_TIMEOUT is not set. #264

Merged
merged 2 commits into from Nov 15, 2016

Conversation

mwringe
Copy link
Contributor

@mwringe mwringe commented Nov 15, 2016

No description provided.

@mwringe
Copy link
Contributor Author

mwringe commented Nov 15, 2016

@jcantrill
Copy link
Contributor

only question... why is timeout removed from the script? is it no longer passed via a switch? otherwise LGTM

@mwringe
Copy link
Contributor Author

mwringe commented Nov 15, 2016

@jcantrill: Thanks.
We have bumped up the default value, so having the timeout specified in the script is no longer needed since the default is more than enough now.

@mwringe
Copy link
Contributor Author

mwringe commented Nov 15, 2016

[merge]

@openshift-bot
Copy link

Evaluated for metrics merge up to 047fbea

@openshift-bot
Copy link

openshift-bot commented Nov 15, 2016

Metrics Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-origin-metrics/171/) (Base Commit: 06bbc53)

@openshift-bot openshift-bot merged commit 9bf52c5 into openshift:master Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants