Create deployment-donut directive with scaling controls #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move some logic from the overview-deployment to a new deployment-donut directive that can be used on other pages like browse -> deployments. This allows us to add the scaling controls anywhere we show the donut.
|
[merge] |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/10/) |
|
Evaluated for origin web console merge up to 1bcef48 |
Merged
f0x11
pushed a commit
to f0x11/origin-web-console
that referenced
this pull request
Dec 7, 2017
Catalog add DataMan OS Microservice governance
JameelB
pushed a commit
to JameelB/origin-web-console
that referenced
this pull request
May 16, 2018
…eClass-issue fix issue with serviceClasses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some logic from the overview-deployment directive to a new deployment-donut directive that can be used on other pages like browse -> deployments. This allows us to add the scaling controls anywhere we show the donut.
Fixes openshift/origin#5295
@jwforres PTAL