New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specify other docker-machine driver for "oc cluster up" #10982

Closed
chmouel opened this Issue Sep 18, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@chmouel
Contributor

chmouel commented Sep 18, 2016

Currently oc cluster up fire docker-machine with virtualbox and there is no way to specify another driver (i.e: xhyve, kvm, etc..)

Version

oc v1.4.0-alpha.0+85eb37b
kubernetes v1.4.0-beta.3+d19513f

Steps To Reproduce

oc cluster up --docker-driver=xhyve

Current Result

error as not implemented

Expected Result

creating oc cluster with the xhyve driver

@smarterclayton

This comment has been minimized.

Show comment
Hide comment
@smarterclayton

smarterclayton Sep 19, 2016

Member

@csrwng can we work this into the existing docker machine flag somehow? Or have a --machine-args? I'm concerned about the sheer number of flags, but the 2-3 most common should be allowed as long as we can clearly explain them. The rest the user can be expected to provide by creating a machine up front themselves.

Member

smarterclayton commented Sep 19, 2016

@csrwng can we work this into the existing docker machine flag somehow? Or have a --machine-args? I'm concerned about the sheer number of flags, but the 2-3 most common should be allowed as long as we can clearly explain them. The rest the user can be expected to provide by creating a machine up front themselves.

@chmouel

This comment has been minimized.

Show comment
Hide comment
@chmouel

chmouel Sep 19, 2016

Contributor

FYI for others that are wondering and looking at this issue, I made a blog post about it (which document how to create a machine up front as well for future) https://blog.chmouel.com/2016/09/19/getting-openshift-origin-cluster-up-working-with-xhyve/

Contributor

chmouel commented Sep 19, 2016

FYI for others that are wondering and looking at this issue, I made a blog post about it (which document how to create a machine up front as well for future) https://blog.chmouel.com/2016/09/19/getting-openshift-origin-cluster-up-working-with-xhyve/

@christian-posta

This comment has been minimized.

Show comment
Hide comment
@christian-posta

christian-posta Sep 23, 2016

+1 @smarterclayton either add --machine-args or --native-virt or something that allows us to create the machine using whatever the native virt technology is with docker-machine

christian-posta commented Sep 23, 2016

+1 @smarterclayton either add --machine-args or --native-virt or something that allows us to create the machine using whatever the native virt technology is with docker-machine

@csrwng

This comment has been minimized.

Show comment
Hide comment
@csrwng

csrwng Sep 30, 2016

Contributor

@smarterclayton given our recent conversation about cluster up not being in the business of creating virtual machines, maybe the right thing to do is to deprecate the --create-machine flag and make it more explicit that you need to have a working Docker for cluster up to work. wdyt?

Contributor

csrwng commented Sep 30, 2016

@smarterclayton given our recent conversation about cluster up not being in the business of creating virtual machines, maybe the right thing to do is to deprecate the --create-machine flag and make it more explicit that you need to have a working Docker for cluster up to work. wdyt?

@csrwng

This comment has been minimized.

Show comment
Hide comment
@csrwng

csrwng Feb 6, 2017

Contributor

Minishift (https://github.com/minishift/minishift) which now uses cluster up under the covers allows you more flexibility to create a VM for it. Closing this in favor of using that to create your vm.

Contributor

csrwng commented Feb 6, 2017

Minishift (https://github.com/minishift/minishift) which now uses cluster up under the covers allows you more flexibility to create a VM for it. Closing this in favor of using that to create your vm.

@csrwng csrwng closed this Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment