New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: ability to mark/flag images so they're excluded from image pruning #12289

Closed
fgiloux opened this Issue Dec 16, 2016 · 6 comments

Comments

Projects
None yet
6 participants
@fgiloux
Contributor

fgiloux commented Dec 16, 2016

"oadm prune images" is a very useful command to clear old images. It takes in consideration images that are in use or have been recently used and allow deleting a pile of images created as part of the development process. It is however for auditing and potential rollback required to keep some old images that may not have been in use for a longer time. Typically images that have been rolled out into production at some point (and decommissioned later on) and have been annotated accordingly.
This enhancement request is to add an option to exclude images with a particular annotation from the pruning operation.

@ncdc

This comment has been minimized.

Show comment
Hide comment
@ncdc

ncdc Dec 16, 2016

Contributor

While an annotation may be appropriate and may be the way this gets implemented, I'd recommend just asking for the basic requirement - a way to mark or flag an image such that it is not considered a candidate for pruning.

Contributor

ncdc commented Dec 16, 2016

While an annotation may be appropriate and may be the way this gets implemented, I'd recommend just asking for the basic requirement - a way to mark or flag an image such that it is not considered a candidate for pruning.

@ncdc ncdc changed the title from Enhancement request: Using annotation with oadm prune images to RFE: ability to mark/flag images so they're excluded from image pruning Dec 16, 2016

@fgiloux

This comment has been minimized.

Show comment
Hide comment
@fgiloux

fgiloux Dec 16, 2016

Contributor

Agreed

Contributor

fgiloux commented Dec 16, 2016

Agreed

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh
Member

soltysh commented Dec 19, 2016

@mfojtik fyi

@pweil- pweil- added the priority/P2 label Dec 19, 2016

@smarterclayton

This comment has been minimized.

Show comment
Hide comment
@smarterclayton

smarterclayton Dec 29, 2016

Member

How would you fit such a tag into your process? Would this be a manual administration step? What criteria would you use to identify the images you would tag?

Member

smarterclayton commented Dec 29, 2016

How would you fit such a tag into your process? Would this be a manual administration step? What criteria would you use to identify the images you would tag?

@fgiloux

This comment has been minimized.

Show comment
Hide comment
@fgiloux

fgiloux Dec 31, 2016

Contributor

It would evolve with the release process, first manual and then automated as part of a release pipeline. The tag would be applied at the time the image is either rolled out into production or marked for roll out.

Contributor

fgiloux commented Dec 31, 2016

It would evolve with the release process, first manual and then automated as part of a release pipeline. The tag would be applied at the time the image is either rolled out into production or marked for roll out.

@mfojtik

This comment has been minimized.

Show comment
Hide comment

@mfojtik mfojtik closed this Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment