Join GitHub today
[3.11 router] dynamic configuration manager support for custom configuration templates #21170
We would be interested to make it work with customized router templates when the customization involves new, custom annotations.
Steps To Reproduce
A blueprint matching the custom annotation is selected, or no blueprint with that annotation is found and router configuration is reloaded completely to enforce the custom configuration.
It seems to me this there could be two ways to support a customized router template with the dynamic manager:
I would be happy to submit a PR for either option.
@alexcern cool. Yeah, adding support for custom templates/annotations was something that we had punted and would love to get a PR for this.
Thinking of this from a general configuration standpoint, something that encompasses both of your options could be useful.
Aside: The configmap idea from above got me thinking it might be worth looking at having some of the router options be dynamically update-able. Some of the options like
Ideally we would set this together with the template itself, since the list of annotations to match is exactly the list of annotations used by the template to vary the configuration. But I could not think of a fine way to integrate this in the template definition.