New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass NAMESPACE_LABELS or ROUTE_LABELS at the creation time of the router #21171

Open
bigon opened this Issue Oct 4, 2018 · 1 comment

Comments

Projects
None yet
4 participants
@bigon

bigon commented Oct 4, 2018

Hi,

When creating a new router for sharding, it's not possible to add the NAMESPACE_LABELS or ROUTE_LABELS atomically. That means that all the existing routes will be exposed to the new created router.

The only way is to set the number of replicas to 0 for the new router, then set the NAMESPACE_LABELS and then scale up, but this feels like a hack:

  1. oc adm router router-ldv --labels='router=ldv' --selector='router=ldv' --service-account=router --replicas=0
  2. oc set env dc/router-ldv NAMESPACE_LABELS="router=ldv"
  3. oc scale deploymentconfig.apps.openshift.io/router-ldv --replicas=1

Shouldn't a way to set the *_LABELS be added to the oc adm router command?

3.10

@jwforres

This comment has been minimized.

Show comment
Hide comment
@jwforres
Member

jwforres commented Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment