Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub webhook URL fails (has wrong case for secret) in Web UI #5195

Closed
sspeiche opened this issue Oct 19, 2015 · 0 comments
Closed

GitHub webhook URL fails (has wrong case for secret) in Web UI #5195

sspeiche opened this issue Oct 19, 2015 · 0 comments
Assignees
Labels
component/web kind/bug Categorizes issue or PR as related to a bug. priority/P1

Comments

@sspeiche
Copy link
Contributor

I just created a new application from template, namely nodejs-mongodb-example, and leaving the GITHUB_WEBHOOK_SECRET blank. The GitHub webhook generated fails, since the secret in the URL is changed to be lowercase. I'm running OSE 3.0.2.0.

From the BC the secret generated is:
Am852WIxLaEfgjioEmgrwvPq7VBkVG4op1QJIeBx

From the Web Console, "Copy to clipboard" (and Show URL) have this:
https://api.engint.openshift.com/oapi/v1/namespaces/nodejs-template-provided-secret/buildconfigs/nodejs-mongodb-example/webhooks/am852wixlaefgjioemgrwvpq7vbkvg4op1qjiebx/github

oc describe bc bc shows the right GitHub webhook URL:
Webhook GitHub: https://api.engint.openshift.com:443/oapi/v1/namespaces/nodejs-template-provided-secret/buildconfigs/nodejs-mongodb-example/webhooks/Am852WIxLaEfgjioEmgrwvPq7VBkVG4op1QJIeBx/github

/cc @jwforres @spadgett

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/web kind/bug Categorizes issue or PR as related to a bug. priority/P1
Projects
None yet
Development

No branches or pull requests

4 participants