New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash autocompletions are not packaged into our binaries #5290

Closed
stevekuznetsov opened this Issue Oct 21, 2015 · 10 comments

Comments

Projects
None yet
6 participants
@stevekuznetsov
Contributor

stevekuznetsov commented Oct 21, 2015

We should package our autocompletions into our releases. It would be nice if they were compiled into the binary and the binary would check for them in the user's home directory and place them if they're not found or outdated.

@sdodson

@sdodson

This comment has been minimized.

Member

sdodson commented Oct 22, 2015

If we're going with the suggestion in the description this is a hack/build-go.sh and golang fix un-related to the installer. I think this should be assigned to the UI/CLI team.

@danmcp

This comment has been minimized.

Member

danmcp commented Nov 2, 2015

@smarterclayton Please provide a replacement priority.

@sdodson

This comment has been minimized.

Member

sdodson commented Nov 21, 2015

@fabianofranz Any thoughts on bundling completions for users who download the client only?

@smarterclayton

This comment has been minimized.

Member

smarterclayton commented Nov 21, 2015

I assume we're just going to have an oc config autocomplete or something?

On Nov 21, 2015, at 6:00 PM, Scott Dodson notifications@github.com wrote:

@fabianofranz https://github.com/fabianofranz Any thoughts on bundling
completions for users who download the client only?


Reply to this email directly or view it on GitHub
#5290 (comment).

@fabianofranz

This comment has been minimized.

Member

fabianofranz commented Nov 23, 2015

oc login could perform the check and update along with the config file handling, and we could have an explicit command to force it manually, oc config complete like @smarterclayton mentioned, for example.
@sdodson I agree this is for the UI team, @danmcp please reassign?

@liggitt

This comment has been minimized.

Contributor

liggitt commented Nov 23, 2015

not sure I want login to do that... config file is within it's set of responsibilities... autocomplete installation probably isn't

@danmcp danmcp assigned fabianofranz and unassigned sdodson Nov 23, 2015

@smarterclayton

This comment has been minimized.

Member

smarterclayton commented Nov 24, 2015

Agree - being able to source an autocomplete file is probably all we should
do for now.

On Nov 23, 2015, at 10:01 AM, Jordan Liggitt notifications@github.com
wrote:

not sure I want login to do that... config file is within it's set of
responsibilities... autocomplete installation probably isn't


Reply to this email directly or view it on GitHub
#5290 (comment).

@fabianofranz

This comment has been minimized.

Member

fabianofranz commented May 30, 2016

Reopening, unless I missed it this was fixed in Kube is still pending a new Kube rebase into origin.

@fabianofranz fabianofranz reopened this May 30, 2016

@stevekuznetsov

This comment has been minimized.

Contributor

stevekuznetsov commented May 30, 2016

Didn't realize Kube PRs could auto-close Origin issues...

@fabianofranz

This comment has been minimized.

Member

fabianofranz commented Jun 22, 2016

Fixed by #9354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment