Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdmin role is not allowing the head verb #5973
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
deads2k
Nov 20, 2015
Contributor
I'm assuming this permission is leading to the ClusterRole here: https://github.com/simon3z/manageiq.org/blob/containers-docs/source/documentation/getting-started.html.md#service-accounts ?
|
I'm assuming this permission is leading to the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
deads2k
Nov 20, 2015
Contributor
@liggitt You want to explicitly list the head verb or assume that our API works correctly and power to get implies power to head?
|
@liggitt You want to explicitly list the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
simon3z
Nov 20, 2015
I'm assuming this permission is leading to the ClusterRole here:
@deads2k correct (there should be a note in that doc to this Issue).
@liggitt You want to explicitly list the head verb or assume that our API works correctly and power to get implies power to head
Adding head didn't work for me. Maybe I overlooked something (or maybe head is not expected as verb).
simon3z
commented
Nov 20, 2015
@deads2k correct (there should be a note in that doc to this Issue).
Adding |
deads2k
referenced this issue
Nov 20, 2015
Merged
UPSTREAM: 17567: handle the HEAD verb correctly for authorization #5985
deads2k
self-assigned this
Nov 20, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
liggitt
Nov 20, 2015
Contributor
@simon3z head method wasn't handled at all. https://github.com/openshift/origin/pull/5985/files#diff-d8a717a6f0dc0916348eea8de58caac5R505 maps it to "get" for API requests
|
@simon3z |
simon3z commentedNov 19, 2015
The
adminrole (and probably other), cannot use theheadverb:This may not be particularly interesting for the kubernetes/openshift api but it applies also to the proxy, effectively preventing
adminsfrom usingheadon any rest-api served by pods and services.cc @deads2k @liggitt