Delete a redundant arg and optimize some codes in the pkg/cmd/admin/registry/registry.go
#10474
Conversation
miaoyq
force-pushed
the
optimization-code-of-registry
branch
from
04e9fad
to
5e53af5
Compare
|
/cc @smarterclayton Thanks! |
miaoyq
force-pushed
the
optimization-code-of-registry
branch
from
5e53af5
to
e2830cf
Compare
|
@smarterclayton Can this PR be merged? thanks! |
| } | ||
|
|
||
| secretEnv = app.Environment{ | ||
| "OPENSHIFT_MASTER": config.Host, | ||
| "OPENSHIFT_CA_DATA": string(config.CAData), | ||
| "OPENSHIFT_KEY_DATA": string(config.KeyData), | ||
| "OPENSHIFT_CERT_DATA": string(config.CertData), | ||
| "OPENSHIFT_INSECURE": insecure, | ||
| "OPENSHIFT_INSECURE": fmt.Sprintf("%v", config.Insecure), |
There was a problem hiding this comment.
It would probably be better to use %t here because we want Insecure to be flagged as a bool.
There was a problem hiding this comment.
Thanks for review! @smarterclayton
Updated.
miaoyq
force-pushed
the
optimization-code-of-registry
branch
from
e2830cf
to
ef6ad21
Compare
|
LGTM [merge] thanks |
|
[Test]ing while waiting on the merge queue |
miaoyq
force-pushed
the
optimization-code-of-registry
branch
from
ef6ad21
to
6ac5580
Compare
miaoyq
force-pushed
the
optimization-code-of-registry
branch
from
6ac5580
to
876471e
Compare
miaoyq
force-pushed
the
optimization-code-of-registry
branch
from
876471e
to
72c1367
Compare
|
@smarterclayton This PR isn't merged still, could you please trigger another test and merge process? Thanks! |
|
[test] |
|
Evaluated for origin test up to 72c1367 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10026/) (Base Commit: 66a729c) |
|
[merge]
|
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10026/) (Image: devenv-rhel7_5179) |
|
Evaluated for origin merge up to 72c1367 |
namespacein thegenerateSecretsConfig, because it is not used.RunCmdRegistry, make it more clean.