Fix gitserver bc search #10576
Merged
Fix gitserver bc search #10576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bparees ptal |
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| matchingBuildConfigs := []*buildapi.BuildConfig{} | ||
|
|
||
| for _, bc := range buildConfigList.Items { |
There was a problem hiding this comment.
go's horrible iteration behavior strikes again, eh?
|
lgtm [merge] |
|
[Test]ing while waiting on the merge queue |
csrwng
force-pushed
the
gitserver_bc_detection
branch
from
405009e
to
8bcc7c8
Compare
|
Evaluated for origin test up to 8bcc7c8 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8325/) |
|
#8221 |
|
[test] |
|
The Origin test job could not be run again for this pull request.
|
|
@stevekuznetsov why isn't the bot respecting @csrwng's flake comment? #10576 (comment) [merge] |
|
@stevekuznetsov nm, i guess the issue @csrwng linked didn't have the flake label. |
|
Evaluated for origin merge up to 8bcc7c8 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8355/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in gitserver search for matching build config (pointer to loop var).
Adds unit test to catch the bug.