New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node should default to controller attach detach #12726
Node should default to controller attach detach #12726
Conversation
This should have been changed in 1.4
01e3e76
to
996ad48
Compare
@sjenning who owns attach detach controller? We need to check that 1.4 isn't broken. |
@smarterclayton why would you ask Derek or Seth? Derek, Seth please ignore. @gnufied can you run this down today? I was about 90% sure we had switched everything to master attach, but maybe I'm wrong (wouldn't be the first time today) |
I asked because Seth was debugging master attach issues the other day. @jsafrane I don't see signs that this is correctly set up in 1.4 from either ansible or openshift code - anything you can do to triage that asap in case we have a significant issues for users and customers on 1.4 clusters is appreciated. |
[test] |
Evaluated for origin test up to 996ad48 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13454/) (Base Commit: ea2e42e) |
@openshift/storage need a reviewer and someone to triage this - if 1.4 is doing attach in both places (which it looks like it is) then I need an assessment whether we need a fix. |
LGTM. volumes can be attached/detached via controller or kubelet, but development and testing focus on controller. There are also good amount of fixes in 1.4 to stablize the controller. |
We are safe, 1.4 is not doing attach in both places. The controller will obey the node's setting which is just an annotation on the node. So at worst the attach detach controller is sitting idle while the nodes do attach themselves |
Ok, and we're 100% sure that annotation is being set correctly in an
openshift 1.4 server?
…On Wed, Feb 1, 2017 at 2:20 PM, Matthew Wong ***@***.***> wrote:
We are safe, 1.4 is not doing attach in both places. The controller will
obey the node's setting which is just an annotation on the node. So at
worst the attach detach controller is sitting idle while the nodes do
attach themselves
https://github.com/kubernetes/kubernetes/blob/
9ae2dfa/pkg/controller/
volume/attachdetach/attach_detach_controller.go#L277
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12726 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p_8WjPCjElaRhoTFes4Pa2P_N_O9ks5rYNr-gaJpZM4LyPre>
.
|
you concern is 'admin set the flag on the node, did the node have permission to update the annotation' ? |
Just that we as a team are 100% sure we know that attach/detach is working correctly at HEAD because otherwise "example scenario" wouldn't even work. If that's the case this goes back to a p2 and do it later. |
Eric suggested we wait to flip the default until 1.6 which makes sense. |
I would suggest this not merge until 3.6. I wouldn't want a 3.5 node (default master attach detach) and a 3.3 master (node attach detach) together. 3.4 the master should be g2g so 3.6 node default would be a good idea. |
@eparis I think we should push for this as default behaviour on 3.5 itself, rather than waiting for 3.6. Looking at bugs we have been getting because cluster doing node side attach/detach - we have a problem at hand. The thing is, Node side attach detach is really bad for variety of reasons:
I am happy to verify and double check, what happens when master is 3.3 and node is 3.5 but controller doing attach/detach has been available since >=3.3. |
[merge] for 1.6 |
Evaluated for origin merge up to 996ad48 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/718/) (Base Commit: 2cac04a) (Image: devenv-rhel7_6011) |
This should have been changed in 1.4, and I don't see anything in the ansible setup that would set it to true. This means that 1.4 installs are probably running with both kubelet attach/detach and controller attach/detach...
@derekwaynecarr
[test]