Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around docker race condition when running build post commit hooks. #13100

Merged
merged 1 commit into from Mar 4, 2017

Conversation

jim-minter
Copy link
Contributor

@jim-minter jim-minter commented Feb 24, 2017

@jim-minter jim-minter self-assigned this Feb 24, 2017
@csrwng
Copy link
Contributor

csrwng commented Feb 24, 2017

👍 I didn't realize we were doing a logs call instead of attach. Makes sense.

@jim-minter jim-minter changed the title [DO NOT MERGE] Work around docker race condition when running build post commit hooks. Work around docker race condition when running build post commit hooks. Mar 2, 2017
@jim-minter
Copy link
Contributor Author

Tested with fork AMI and seems to solve the problem.

@jim-minter jim-minter assigned bparees and unassigned jim-minter Mar 2, 2017
@jim-minter
Copy link
Contributor Author

@bparees this should go into release-1.5 as well - does that require a second PR? Once this has merged or concurrently?

@bparees
Copy link
Contributor

bparees commented Mar 2, 2017

@bparees this should go into release-1.5 as well - does that require a second PR? Once this has merged or concurrently?

yes it needs a second pr against the release-1.5 branch, concurrent is fine.

@bparees
Copy link
Contributor

bparees commented Mar 2, 2017

[testextended][extended:core(builds)]

@bparees
Copy link
Contributor

bparees commented Mar 2, 2017

[test]

@bparees
Copy link
Contributor

bparees commented Mar 2, 2017

@jim-minter failure looks legitimate.

@bparees
Copy link
Contributor

bparees commented Mar 2, 2017

(or the merge queue is broken)

@bparees
Copy link
Contributor

bparees commented Mar 2, 2017

merge tag removed, this breaks an extended test.

@jim-minter
Copy link
Contributor Author

Yes, sorry, repushed and hopefully fixed. Let's see the test results. Ditto on #13196.

@bparees
Copy link
Contributor

bparees commented Mar 2, 2017

@jim-minter I think the extended tests are still going to fail.

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to e97d96b

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to e97d96b

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/795/) (Base Commit: ad8ea70)

@jim-minter
Copy link
Contributor Author

flake #13068

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/1151/) (Base Commit: ad8ea70) (Extended Tests: core(builds))

@bparees
Copy link
Contributor

bparees commented Mar 3, 2017

[merge]

@bparees
Copy link
Contributor

bparees commented Mar 3, 2017

flake #13234
[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to e97d96b

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 4, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/828/) (Base Commit: 8b1ddd5) (Image: devenv-rhel7_6035)

@openshift-bot openshift-bot merged commit 3e26eed into openshift:master Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants