New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding X-Forwarded-For header to reencrypt route #14142
adding X-Forwarded-For header to reencrypt route #14142
Conversation
|
@openshift/networking @knobunc PTAL |
|
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@JacobTanenbaum Can you take the : out of the commit message in "Bug: 1449022" please? I think the : confuses the commit hook's parser. |
add X-Forwarded-For header for reencrypt routes, just as it is for edge routes Bug 1449022
44ba2e3
to
5011cb4
Compare
|
Evaluated for origin test up to 5011cb4 |
|
@JacobTanenbaum thanks. [merge] |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1361/) (Base Commit: 2628c77) |
|
[merge] looking for flake number |
|
Evaluated for origin merge up to 5011cb4 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/634/) (Base Commit: f793124) (Image: devenv-rhel7_6228) |
add X-Forwarded-For header for reencrypt routes, just as it is for edge routes
Bug: 1449022 Link