Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding X-Forwarded-For header to reencrypt route #14142

Merged
merged 1 commit into from May 13, 2017

Conversation

JacobTanenbaum
Copy link
Contributor

add X-Forwarded-For header for reencrypt routes, just as it is for edge routes

Bug: 1449022 Link

@JacobTanenbaum
Copy link
Contributor Author

@openshift/networking @knobunc PTAL

@JacobTanenbaum
Copy link
Contributor Author

[test]

Copy link
Contributor

@rajatchopra rajatchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knobunc
Copy link
Contributor

knobunc commented May 11, 2017

@JacobTanenbaum Can you take the : out of the commit message in "Bug: 1449022" please? I think the : confuses the commit hook's parser.

add X-Forwarded-For header for reencrypt routes, just as it is for edge routes

Bug 1449022
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 5011cb4

@knobunc
Copy link
Contributor

knobunc commented May 11, 2017

@JacobTanenbaum thanks. [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1361/) (Base Commit: 2628c77)

@eparis
Copy link
Member

eparis commented May 13, 2017

[merge] looking for flake number

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 5011cb4

@openshift-bot
Copy link
Contributor

openshift-bot commented May 13, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/634/) (Base Commit: f793124) (Image: devenv-rhel7_6228)

@openshift-bot openshift-bot merged commit c1160be into openshift:master May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants