Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: honor BindAddress for the iptables proxy #14815

Merged

Conversation

dcbw
Copy link
Member

@dcbw dcbw commented Jun 21, 2017

A loose port of kubernetes/kubernetes#46678

If the configuration specifies a BindAddress, we should probably
honor it. If the configuration doesn't, and there is no default
route with which to autodetect the node address, then the user
really needs to tell the proxy what address to use via BindAddress.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1462428

@openshift/networking @knobunc

A loose port of kubernetes/kubernetes#46678

If the configuration specifies a BindAddress, we should probably
honor it.  If the configuration doesn't, and there is no default
route with which to autodetect the node address, then the user
really needs to tell the proxy what address to use via BindAddress.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1462428
@dcbw dcbw force-pushed the iptables-proxy-honor-BindAddress branch 2 times, most recently from 369c486 to c9b91fa Compare June 21, 2017 20:28
Copy link
Contributor

@danwinship danwinship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knobunc
Copy link
Contributor

knobunc commented Jun 22, 2017

[test][testextended][extended: networking]

@knobunc
Copy link
Contributor

knobunc commented Jun 22, 2017

[merge][severity: blocker]

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to c9b91fa

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to c9b91fa

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to c9b91fa

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended/687/) (Base Commit: 7657e99) (PR Branch Commit: c9b91fa) (Extended Tests: networking)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2509/) (Base Commit: 7657e99) (PR Branch Commit: c9b91fa)

@knobunc
Copy link
Contributor

knobunc commented Jun 22, 2017

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 22, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1087/) (Base Commit: 651dd88) (PR Branch Commit: c9b91fa) (Extended Tests: blocker) (Image: devenv-rhel7_6392)

@smarterclayton
Copy link
Contributor

Will this break existing users?

@openshift-bot openshift-bot merged commit 4423ff5 into openshift:master Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants