Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make GC mutation check ignore selfLink #15112

Merged
merged 1 commit into from Jul 12, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 10, 2017

fixes #15044

Got a reproducer here https://bugzilla.redhat.com/attachment.cgi?id=1295674 and for some reason the selfLink was causing the GC mutation check to fail.

@mfojtik do you have someone itching to learn about GC?

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to afbed8d

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3030/) (Base Commit: 18c5730) (PR Branch Commit: afbed8d)

@ironcladlou
Copy link
Contributor

LGTM for the specific problem case, but I still wonder if this is comprehensive. Consider a scenario where the request obj omits certain immutable metadata fields like creationTimestamp- wouldn't the old object from storage have creationTimestamp populated, resulting in another false positive diff?

@deads2k
Copy link
Contributor Author

deads2k commented Jul 10, 2017

Consider a scenario where the request obj omits certain immutable metadata fields like creationTimestamp- wouldn't the old object from storage have creationTimestamp populated, resulting in another false positive diff?

That wouldn't cause a problem on patches. This fails for patches which aren't trying to modify anything else.

[merge][severity:blocker]

@liggitt
Copy link
Contributor

liggitt commented Jul 11, 2017

flaked on

Expected
    <int>: 0
to be >
    <int>: 0
/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/daemon_set.go:445

[merge]

@deads2k
Copy link
Contributor Author

deads2k commented Jul 12, 2017

re[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to afbed8d

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 12, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1273/) (Base Commit: 14f47f9) (PR Branch Commit: afbed8d) (Extended Tests: blocker) (Image: devenv-rhel7_6438)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sending propagationPolicy for a Terminating pod results in the pod stuck in storage
4 participants