UPSTREAM: <carry>: Do not error out on pods in kube-system #15513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheduling tests are too aggressive about the health of kube-system.
openshift-merge-robot
added
the
size/XS
|
/approve no-issue
…On Thu, Jul 27, 2017 at 3:23 PM, OpenShift Merge Robot < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *smarterclayton
<#15513#>*
*No associated issue*. Update pull-request body to add a reference to an
issue, or get approval with /approve no-issue
The full list of commands accepted by this bot can be found here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
Needs approval from an approver in each of these OWNERS Files:
- vendor/k8s.io/kubernetes/test/e2e/scheduling/OWNERS
<https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/test/e2e/scheduling/OWNERS>
[smarterclayton]
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15513 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p-KIoYvEOtjKmA6GE04Hkh9AZCtdks5sSOOhgaJpZM4OlujT>
.
|
openshift-merge-robot
added
the
approved
|
|
I'm asking you to review
On Jul 28, 2017, at 10:24 AM, Steve Kuznetsov <notifications@github.com> wrote:
Submit Queue — PR does not have lgtm label.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15513 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p9XkLbc5P-Qs8Z9_EeNu8_jmkigNks5sSe8ngaJpZM4OlujT>
.
|
|
Oh, ok. Lol |
|
/assign |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, stevekuznetsov Associated issue requirement bypassed by: smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, stevekuznetsov Associated issue requirement bypassed by: smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduling tests are too aggressive about the health of kube-system.
Some gce tests are failing because Prometheus is in not ready state on the master.