provide a tag when pulling images so we only pull a single image #15967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
size/XS
openshift-merge-robot
added
the
approved
|
@csrwng ptal |
mfojtik
reviewed
Aug 24, 2017
pkg/build/builder/dockerutil.go
Outdated
| @@ -110,8 +110,15 @@ func pullImage(client DockerClient, name string, authConfig docker.AuthConfigura | |||
| logProgress := func(s string) { | |||
| glog.V(0).Infof("%s", s) | |||
| } | |||
| tag := "latest" | |||
There was a problem hiding this comment.
make this const (maybe there is already const in image api :-)
There was a problem hiding this comment.
i think ParseDockerImageReference giving you DockerImageReference that has Tag is your best bet :-)
There was a problem hiding this comment.
eventually reference.ParseNamedDockerImageReference(spec) which is what ParseDockerImageReference use internally.
Or github.com/docker/distribution/reference.ParseNamed() if you want to be hard-core
openshift-merge-robot
added
size/S
|
@smarterclayton since you were aware of this pulling behavior, ptal. |
|
lgtm |
|
@smarterclayton updated. |
|
/retest |
|
@jim-minter ptal |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, jim-minter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest
…On Sat, Aug 26, 2017 at 8:50 AM, OpenShift CI Robot < ***@***.***> wrote:
@bparees <https://github.com/bparees>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 7fac415
<7fac415>
link
<https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/15967/test_pull_request_origin_extended_conformance_gce/6704/> /test
extended_conformance_gce
Full PR test history <https://openshift-gce-devel.appspot.com/pr/15967>. Your
PR dashboard <https://openshift-gce-devel.appspot.com/pr/bparees>. Please
help us cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/openshift/origin/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15967 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEvl3vhFI18TbdIZJTb6uHkaDlxuNvNBks5scBSHgaJpZM4PB3yf>
.
--
Ben Parees | OpenShift
|
|
/retest
…On Sat, Aug 26, 2017 at 9:35 AM, OpenShift CI Robot < ***@***.***> wrote:
@bparees <https://github.com/bparees>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 7fac415
<7fac415>
link
<https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/15967/test_pull_request_origin_extended_conformance_gce/6705/> /test
extended_conformance_gce
Full PR test history <https://openshift-gce-devel.appspot.com/pr/15967>. Your
PR dashboard <https://openshift-gce-devel.appspot.com/pr/bparees>. Please
help us cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/openshift/origin/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15967 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEvl3vByYVaZ2R2yYxuWzwPakgafP3cwks5scB8ygaJpZM4PB3yf>
.
--
Ben Parees | OpenShift
|
|
/retest |
|
/retest
Ben Parees | OpenShift
…On Aug 26, 2017 5:05 PM, "OpenShift CI Robot" ***@***.***> wrote:
@bparees <https://github.com/bparees>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 7fac415
<7fac415>
link
<https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/15967/test_pull_request_origin_extended_conformance_gce/6725/> /test
extended_conformance_gce
Full PR test history <https://openshift-gce-devel.appspot.com/pr/15967>. Your
PR dashboard <https://openshift-gce-devel.appspot.com/pr/bparees>. Please
help us cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/openshift/origin/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15967 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEvl3ufc_nCjnjgUlLhiE3JlJLnvADIFks5scIh6gaJpZM4PB3yf>
.
|
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 15967, 15990) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15954