ensure new endpoint is registered before testing it #16067
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
size/M
openshift-merge-robot
added
the
approved
|
/test extended_image_ecosystem @openshift/devex ptal |
bparees
force-pushed
the
ecosystem_flakes
branch
2 times, most recently
from
868cef7
to
98f1b7c
Compare
|
/test extended_image_ecosystem |
| newEndpoint, err := oc.KubeFramework().ClientSet.Core().Endpoints(oc.Namespace()).Get(dcName, metav1.GetOptions{}) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| if err != nil { | ||
| return false, err |
There was a problem hiding this comment.
cannot be hit because of prior o.Expect(err).NotTo(o.HaveOccurred())
There was a problem hiding this comment.
thanks, removed the expects (err is handled outside the wait block)
|
@bparees one minor issue (which occurs in multiple files, maybe we should see if this can be refactored one day) then lgtm |
bparees
force-pushed
the
ecosystem_flakes
branch
from
98f1b7c
to
b05a329
Compare
yeah, I gladly admit there is room for further improvement. |
|
/test extended_image_ecosystem |
|
/retest |
|
/retest |
|
@bparees: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
this is going to fail until the junit issue is fixed, and the junit PR is going to fail until this is fixed, but this has passed the relevant test, so manually merging. |
No description provided.