Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added networking team members to the relevant oc adm commands #16375

Merged
merged 1 commit into from Sep 22, 2017
Merged

Added networking team members to the relevant oc adm commands #16375

merged 1 commit into from Sep 22, 2017

Conversation

knobunc
Copy link
Contributor

@knobunc knobunc commented Sep 15, 2017

The networking team owns 'oc adm router' and parts of 'oc adm
diagnostics' so I've added relevant team members to the owners files.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 15, 2017
@knobunc
Copy link
Contributor Author

knobunc commented Sep 15, 2017

/assign @fabianofranz

juanvallejo
juanvallejo reviewed Sep 15, 2017
View reviewed changes
pkg/oc/admin/router/OWNERS Outdated
approvers:
- rajatchopra
- knobunc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline here is unneeded, otherwise this lgtm

@knobunc knobunc mentioned this pull request Sep 15, 2017
Merged
@fabianofranz
Copy link
Member

Add me and @juanvallejo since we can still review and approve CLI-related things here (help, CLI framework changes, etc) and remove the unnecessary line break. Tks!

@knobunc
Added networking team members to the relevant oc adm commands
1b8cae1 
The networking team owns 'oc adm router' and parts of 'oc adm
diagnostics' so I've added relevant team members to the owners files.
@knobunc
Copy link
Contributor Author

knobunc commented Sep 19, 2017

@juanvallejo @fabianofranz thanks, changed as requested.

@knobunc
Copy link
Contributor Author

knobunc commented Sep 21, 2017

/retest

There is no way that this can be causing failures.

@fabianofranz
Copy link
Member

/lgtm
/approve no-issue

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, knobunc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 7992332 into openshift:master Sep 22, 2017
@knobunc knobunc deleted the fix/add-networking-owners branch June 7, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvallejo juanvallejo juanvallejo left review comments

Assignees

@fabianofranz fabianofranz

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@knobunc @fabianofranz @openshift-merge-robot @openshift-bot @juanvallejo @openshift-ci-robot