New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 52917: add --selector support to drain,cordon #16445

Closed
wants to merge 3 commits into
base: master
from

Conversation

@juanvallejo
Member

juanvallejo commented Sep 19, 2017

Related Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1466390
Related Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1466382

Adds --selector option to oc adm drain,cordon,uncordon, performing
each action on a list of nodes matching the given label.

If at least one node fails to be cordoned/uncordoned, the command will
continue to operate on any remaining nodes, uninterrupted, reporting
any errors it encounters along the way.

If at least one node fails to be drained, the command will halt, printing
the immediate error encountered, and a list of nodes yet to be drained
(including the node that just failed to be drained).

Work in progress.
TODO

  • add tests

cc @openshift/cli-review @soltysh

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Sep 21, 2017

Member

@soltysh thanks for the review, will open upstream PR

Member

juanvallejo commented Sep 21, 2017

@soltysh thanks for the review, will open upstream PR

@soltysh

One more comment.

Show outdated Hide outdated vendor/k8s.io/kubernetes/pkg/kubectl/cmd/drain.go Outdated
Show outdated Hide outdated test/cmd/admin.sh Outdated
@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Sep 22, 2017

Member

I'm tagging this as do-not-merge, until an actual upstream commit is present. I don't want to end up with this being merged before upstream will be created and approved.

Member

soltysh commented Sep 22, 2017

I'm tagging this as do-not-merge, until an actual upstream commit is present. I don't want to end up with this being merged before upstream will be created and approved.

@juanvallejo juanvallejo changed the title from UPSTREAM: 0000: add --selector support to drain,cordon to UPSTREAM: 52917: add --selector support to drain,cordon Sep 22, 2017

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Sep 22, 2017

Member

/test cmd

Member

juanvallejo commented Sep 22, 2017

/test cmd

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Sep 25, 2017

Member

/test cmd

Member

juanvallejo commented Sep 25, 2017

/test cmd

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Sep 28, 2017

Member

Still waiting for upstream approval.

Member

soltysh commented Sep 28, 2017

Still waiting for upstream approval.

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Oct 5, 2017

Member

@soltysh thanks, upstream PR has merged

Member

juanvallejo commented Oct 5, 2017

@soltysh thanks, upstream PR has merged

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 5, 2017

Contributor

hold upstreams for rebase

Contributor

liggitt commented Oct 5, 2017

hold upstreams for rebase

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 5, 2017

Contributor

hold upstreams for rebase

Contributor

liggitt commented Oct 5, 2017

hold upstreams for rebase

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Oct 11, 2017

Member

@liggitt @soltysh is this good to go?

Member

juanvallejo commented Oct 11, 2017

@liggitt @soltysh is this good to go?

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Oct 12, 2017

Member

@liggitt thanks, review comments addressed. Will go ahead and update drain.go upstream if everything looks okay.

https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/drain.go#L240-L253

Member

juanvallejo commented Oct 12, 2017

@liggitt thanks, review comments addressed. Will go ahead and update drain.go upstream if everything looks okay.

https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/drain.go#L240-L253

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Oct 12, 2017

Member

/retest

Member

juanvallejo commented Oct 12, 2017

/retest

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo
Member

juanvallejo commented Oct 16, 2017

@soltysh

/lgtm

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Oct 20, 2017

Member

/assign fabianofranz

Member

juanvallejo commented Oct 20, 2017

/assign fabianofranz

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 21, 2017

Contributor

/lgtm

Contributor

liggitt commented Oct 21, 2017

/lgtm

@openshift-merge-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-merge-robot

openshift-merge-robot Oct 21, 2017

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, liggitt, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Contributor

openshift-merge-robot commented Oct 21, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, liggitt, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Nov 9, 2017

Member

/test extended_conformance_gce

Member

juanvallejo commented Nov 9, 2017

/test extended_conformance_gce

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Nov 14, 2017

Member

/retest

Please review the full test history for this PR and help us cut down flakes.

Member

openshift-bot commented Nov 14, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Nov 14, 2017

Member

/test extended_conformance_install
/test extended_conformance_install_update

Member

juanvallejo commented Nov 14, 2017

/test extended_conformance_install
/test extended_conformance_install_update

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Nov 14, 2017

Member

/test extended_conformance_install_update

Member

juanvallejo commented Nov 14, 2017

/test extended_conformance_install_update

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Nov 15, 2017

Member

/retest

Please review the full test history for this PR and help us cut down flakes.

Member

openshift-bot commented Nov 15, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Nov 15, 2017

Member

/retest

Please review the full test history for this PR and help us cut down flakes.

Member

openshift-bot commented Nov 15, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Nov 15, 2017

Member

/test extended_conformance_install_update

Member

juanvallejo commented Nov 15, 2017

/test extended_conformance_install_update

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Nov 15, 2017

Member

/retest

Please review the full test history for this PR and help us cut down flakes.

Member

openshift-bot commented Nov 15, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Nov 16, 2017

Member

/retest

Please review the full test history for this PR and help us cut down flakes.

Member

openshift-bot commented Nov 16, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Nov 16, 2017

Member

/retest

Please review the full test history for this PR and help us cut down flakes.

Member

openshift-bot commented Nov 16, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Nov 16, 2017

Member

/test extended_conformance_install_update

Member

juanvallejo commented Nov 16, 2017

/test extended_conformance_install_update

@openshift-merge-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-merge-robot

openshift-merge-robot Nov 16, 2017

Contributor

/lgtm cancel //PR changed after LGTM, removing LGTM. @fabianofranz @juanvallejo @liggitt @soltysh

Contributor

openshift-merge-robot commented Nov 16, 2017

/lgtm cancel //PR changed after LGTM, removing LGTM. @fabianofranz @juanvallejo @liggitt @soltysh

juanvallejo added some commits Sep 19, 2017

@openshift-ci-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-ci-robot

openshift-ci-robot Nov 20, 2017

@juanvallejo: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update 68c59ce link /test extended_conformance_install_update
ci/openshift-jenkins/cmd 5c02473 link /test cmd
ci/openshift-jenkins/extended_conformance_gce 5c02473 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot commented Nov 20, 2017

@juanvallejo: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update 68c59ce link /test extended_conformance_install_update
ci/openshift-jenkins/cmd 5c02473 link /test cmd
ci/openshift-jenkins/extended_conformance_gce 5c02473 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-merge-robot

openshift-merge-robot Nov 20, 2017

Contributor

@juanvallejo PR needs rebase

Contributor

openshift-merge-robot commented Nov 20, 2017

@juanvallejo PR needs rebase

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Dec 6, 2017

Member

Closing as the current rebase will be introducing these commits to origin

Member

juanvallejo commented Dec 6, 2017

Closing as the current rebase will be introducing these commits to origin

@juanvallejo juanvallejo closed this Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment