Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for JenkinsPipeline strategy env update #17204

Conversation

juanvallejo
Copy link
Contributor

Pick of #17203

Adds support for updating environment variables on buildConfigs
that use the JenkinsPipeline strategy.

/kind bug

cc @openshift/cli-review @bparees

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juanvallejo
We suggest the following additional approver: mfojtik

Assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@bparees
Copy link
Contributor

bparees commented Nov 6, 2017

not sure what the intent of this pick is? if you're trying to backport it to ocp3.6, you need to create the PR directly against the OSE repo(in the release-3.6 branch) these days, i believe.

but i'm also not convinced this rises to the level of justifying a backport.

@juanvallejo
Copy link
Contributor Author

@bparees

not sure what the intent of this pick is? if you're trying to backport it to ocp3.6, you need to create the PR directly against the OSE repo(in the release-3.6 branch) these days, i believe.

Thanks, yes the pick was meant to be a backport.

but i'm also not convinced this rises to the level of justifying a backport.

Will close and comment on bugzilla, thanks

@openshift-ci-robot
Copy link

@juanvallejo: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce dbb6cff link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install_update dbb6cff link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@juanvallejo juanvallejo closed this Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants