New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "UPSTREAM: 53916: update .dockercfg data to config.json format #18062

Merged
merged 2 commits into from Jan 17, 2018

Conversation

@soltysh
Member

soltysh commented Jan 11, 2018

Addresses problem described in https://bugzilla.redhat.com/show_bug.cgi?id=1531511 and https://bugzilla.redhat.com/show_bug.cgi?id=1476330

This reverts commit 8363697, to make it compatible with kubectl create secret docker-registry from k8s 1.7.

@juanvallejo ptal

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Jan 11, 2018

Member

Fixes #17197

Member

soltysh commented Jan 11, 2018

Fixes #17197

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Jan 11, 2018

Member

Fixes #18059

Member

soltysh commented Jan 11, 2018

Fixes #18059

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Jan 12, 2018

Member

/lgtm

Member

juanvallejo commented Jan 12, 2018

/lgtm

@soltysh

This comment has been minimized.

Show comment
Hide comment
@soltysh

soltysh Jan 15, 2018

Member

Fixes #18072

Member

soltysh commented Jan 15, 2018

Fixes #18072

@juanvallejo

This comment has been minimized.

Show comment
Hide comment
@juanvallejo

juanvallejo Jan 15, 2018

Member

cc @mfojtik for approval

Member

juanvallejo commented Jan 15, 2018

cc @mfojtik for approval

@mfojtik

This comment has been minimized.

Show comment
Hide comment
@mfojtik

mfojtik Jan 17, 2018

Member

/approve no-issue

Member

mfojtik commented Jan 17, 2018

/approve no-issue

@openshift-ci-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-ci-robot

openshift-ci-robot Jan 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-ci-robot commented Jan 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-merge-robot

openshift-merge-robot Jan 17, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

openshift-merge-robot commented Jan 17, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-merge-robot

openshift-merge-robot Jan 17, 2018

Contributor

Automatic merge from submit-queue.

Contributor

openshift-merge-robot commented Jan 17, 2018

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit f972e1b into openshift:release-3.7 Jan 17, 2018

14 of 15 checks passed

Submit Queue Required Github CI test is not green: ci/openshift-jenkins/extended_conformance_install
Details
ci/openshift-jenkins/cmd Jenkins job succeeded.
Details
ci/openshift-jenkins/cross Skipped
ci/openshift-jenkins/end_to_end Jenkins job succeeded.
Details
ci/openshift-jenkins/extended_builds Skipped
ci/openshift-jenkins/extended_clusterup Skipped
ci/openshift-jenkins/extended_conformance_gce Jenkins job succeeded.
Details
ci/openshift-jenkins/extended_conformance_install Jenkins job succeeded.
Details
ci/openshift-jenkins/extended_image_ecosystem Skipped
ci/openshift-jenkins/extended_image_registry Skipped
ci/openshift-jenkins/extended_networking_minimal Jenkins job succeeded.
Details
ci/openshift-jenkins/integration Jenkins job succeeded.
Details
ci/openshift-jenkins/unit Jenkins job succeeded.
Details
ci/openshift-jenkins/verify Jenkins job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@soltysh soltysh deleted the soltysh:issue17197 branch Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment