Bug 1538006 - Improve error page when console not installed #18680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
|
I don't feel strongly. 404 is a 404. |
spadgett
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
I don't really care, but if it improves your life. /lgtm Someone is going to complain that they can't customize it. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test unit |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a (very) basic error page for when the console is not installed.
Suggestions to make this better? It's hard to get specific in the error description since it's a generic service proxy.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1538006
/assign @deads2k
@jwforres @smarterclayton FYI