Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1538006 - Improve error page when console not installed #18680

Merged
merged 1 commit into from Mar 11, 2018

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Feb 20, 2018

Adds a (very) basic error page for when the console is not installed.

Suggestions to make this better? It's hard to get specific in the error description since it's a generic service proxy.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1538006

screen shot 2018-02-20 at 12 06 51 pm

/assign @deads2k
@jwforres @smarterclayton FYI

@deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 20, 2018

I don't feel strongly. 404 is a 404.

@spadgett spadgett changed the title [WIP] Bug 1538006 - Improve error page when console not installed Bug 1538006 - Improve error page when console not installed Feb 20, 2018
@deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 26, 2018

I don't really care, but if it improves your life.

/lgtm

Someone is going to complain that they can't customize it.

@openshift-ci-robot
Copy link

@openshift-ci-robot openshift-ci-robot commented Feb 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

@spadgett spadgett commented Feb 27, 2018

/test unit

@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Mar 10, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

@openshift-merge-robot openshift-merge-robot commented Mar 11, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

@openshift-merge-robot openshift-merge-robot commented Mar 11, 2018

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit bf0cf42 into openshift:master Mar 11, 2018
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants