Make v1beta3 the default API version for clients #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarterclayton
force-pushed
the
make_v1beta3_default
branch
from
0767b79
to
fed4e7a
Compare
|
[test] |
smarterclayton
force-pushed
the
make_v1beta3_default
branch
2 times, most recently
from
7bb9b2a
to
acb4351
Compare
|
@derekwaynecarr I ended up making the project admission control allow CREATE on an empty namespace in order to make cluster access review work (I currently have it as namespace scoped). We may end up needing to create a "both" scope... |
smarterclayton
force-pushed
the
make_v1beta3_default
branch
2 times, most recently
from
e28ba22
to
f7c6aab
Compare
|
@derekwaynecarr @deads2k review at your leisure, this is going in though. |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/1894/) (Image: devenv-fedora_1495) |
|
@liggitt did the UI test actually prevent me from breaking the UI?!?!?! |
|
shockingly, yes |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2109/) |
smarterclayton
force-pushed
the
make_v1beta3_default
branch
from
267c934
to
343eed0
Compare
Need to figure out whether objects are safe enough.
Cluster access reviews are posting to an empty namespace
* Remove imageRepository* * Remove deployments * Fix a round trip error in output.to for ImageStreamTags
Output should default to ImageStreamTag in v1beta3 onward.
smarterclayton
force-pushed
the
make_v1beta3_default
branch
from
343eed0
to
f28b5ec
Compare
|
[merge] |
|
Evaluated for origin up to f28b5ec |
openshift-bot
pushed a commit
that referenced
this pull request
May 12, 2015
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is in a different pull