Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/controller/build: simplify bool exprs #20542

Merged
merged 1 commit into from
Aug 5, 2018
Merged

build/controller/build: simplify bool exprs #20542

merged 1 commit into from
Aug 5, 2018

Conversation

quasilyte
Copy link
Contributor

Remove extra negation by using proper "opposite" comparison operations.

Found using https://go-critic.github.io/overview#boolExprSimplify-ref

Remove extra negation by using proper "opposite" comparison operations.

Found using https://go-critic.github.io/overview#boolExprSimplify-ref
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2018
@quasilyte
Copy link
Contributor Author

/assign @smarterclayton

@bparees
Copy link
Contributor

bparees commented Aug 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2018
@bparees
Copy link
Contributor

bparees commented Aug 5, 2018

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, Quasilyte

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2018
@bparees
Copy link
Contributor

bparees commented Aug 5, 2018

/unassign @smarterclayton
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants