fix formatString describe helper #21304
Conversation
| @@ -75,7 +75,7 @@ func formatString(out *tabwriter.Writer, label string, v interface{}) { | |||
|
|
|||
| fmt.Fprintf(out, fmt.Sprintf("%s:", label)) | |||
| for _, lval := range labelVals { | |||
| fmt.Fprintf(out, fmt.Sprintf("\t%s\n", lval)) | |||
| fmt.Fprintln(out, fmt.Sprintf("\t%s", lval)) | |||
There was a problem hiding this comment.
What was wrong with the previous one? The current won't work, b/c fmt.Fprintln does not accept format parameter, see https://golang.org/pkg/fmt/#Fprintln.
There was a problem hiding this comment.
The current won't work, b/c fmt.Fprintln does not accept format parameter
@soltysh I'd say that's precisely why Fprintln fixes the issue :) The problem was that label values containing % were being incorrectly interpreted as fmt strings. From the bugzilla:
Log Tail: Pulled 2/2 layers, 100%!c(MISSING)omplete
Extracting
Pulling image golang:1.10.3 ...
error: build error: no such image
There was a problem hiding this comment.
My bad, I was parsing this line wrongly.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanvallejo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/refresh |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1628789
cc @smarterclayton @soltysh