New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properly handle object creation error in template instantiate #21704
Conversation
5ba7b56
to
116f3b2
Compare
/assign @coreydaley |
@smarterclayton fyi |
116f3b2
to
4825255
Compare
4825255
to
c6dd1b3
Compare
/test e2e-aws-all |
c6dd1b3
to
91ee6b5
Compare
missed a file save. updated. |
/test e2e-aws-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small grammatical nit,
91ee6b5
to
eac2334
Compare
/test e2e-aws-all |
}) | ||
|
||
g.It("should report a failure on creation", func() { | ||
var err error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question here: Why use var err error here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was copied from another test, might have made more sense the way the other test was structured.
anyway i had to redo the test a bit so now that's gone.
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
eac2334
to
0b08b1c
Compare
New changes are detected. LGTM label has been removed. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-aws-all |
/lgtm |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, coreydaley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the new test passed in e2e-gcp so we can let the bot take it from here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@bparees: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/skip
Ben Parees | OpenShift
…On Tue, Dec 25, 2018, 19:46 OpenShift CI Robot ***@***.*** wrote:
@bparees <https://github.com/bparees>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
ci/prow/e2e-aws-all 0b08b1c
<0b08b1c>
link
<https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/21704/pull-ci-openshift-origin-master-e2e-aws-all/21> /test
e2e-aws-all
Full PR test history <https://openshift-gce-devel.appspot.com/pr/21704>. Your
PR dashboard <https://openshift-gce-devel.appspot.com/pr/bparees>. Please
help us cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/openshift/origin/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21704 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEvl3t3rouNHZCtcQMIUWQFpqDJHhYvUks5u8sa7gaJpZM4ZgHLg>
.
|
It's a Christmas miracle.
Ben Parees | OpenShift
…On Tue, Dec 25, 2018, 20:01 OpenShift Merge Robot ***@***.*** wrote:
Merged #21704 <#21704> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21704 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEvl3gXXiLGYoTBGVi_yBYmQjYGAQ6EUks5u8spPgaJpZM4ZgHLg>
.
|
https://bugzilla.redhat.com/show_bug.cgi?id=1661845