Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] MetricsApiProxy diagnostic: fix endpoint #21752

Merged

Conversation

sosiouxme
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2019
@sosiouxme sosiouxme changed the title MetricsApiProxy diagnostic: fix endpoint [3.11] MetricsApiProxy diagnostic: fix endpoint Jan 8, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@sosiouxme
Copy link
Member Author

/retest

@sosiouxme
Copy link
Member Author

@dgoodwin could you /lgtm this? i don't think anyone really has domain expertise here. Also #21751 is the same for 3.10 (tests keep flaking though)

@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sosiouxme
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit e983b72 into openshift:release-3.11 Jan 11, 2019
@sosiouxme sosiouxme deleted the release-3.11 branch January 14, 2019 20:21
@sosiouxme sosiouxme restored the release-3.11 branch January 14, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants