UPSTREAM: <carry>: require good status on discovery check #21758
Conversation
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
openshift-controller-manager /retest |
|
/retest |
|
tagging because I think this will unstick us. @sttts feel free to object post-merge |
deads2k
force-pushed
the
require-good-status
branch
from
5b58d48
to
11a7ff5
Compare
|
New changes are detected. LGTM label has been removed. |
|
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Merging to improve us |
The aggregator shouldn't report the status on an endpoint to be good unless it gets back a 200-ish return code. This builds the correct transport so that a unauthorized should pop out if the backing apiserver would return one.
/assign @sttts
I'm actually not sure how to wire this upstream since the proxy transport is created in an odd way and we couldn't/shouldn't modify it here. We already customized this to hit many in parallel, what's one more :(
@mfojtik checking at the other end.