Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport-3.10] Fix issue where wildcard routes get 503s intermittently. #22112

Merged
merged 1 commit into from Feb 21, 2019

Conversation

ramr
Copy link
Contributor

@ramr ramr commented Feb 20, 2019

Couldn't cherrypick from #22087 due to conflicts in the unit test file (import package name changes), so this is a new PR. Code fixes are the same.

As part of the resync processing, wildcard routes get a "HostAlreadyClaimed"
error and then later as part of the same event processing flow, the route
gets re-added. This results in a temporary outage (route returns 503s).

fixes #1660647 (https://bugzilla.redhat.com/show_bug.cgi?id=1660647)

@openshift/sig-network-edge PTAL Thx

As part of the resync processing, wildcard routes get a "HostAlreadyClaimed"
error and then later as part of the same event processing flow, the route
gets re-added. This results in a temporary outage (route returns 503s).

fixes #1660647 (https://bugzilla.redhat.com/show_bug.cgi?id=1660647)
@openshift-ci-robot openshift-ci-robot added sig/network-edge size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2019
@ramr
Copy link
Contributor Author

ramr commented Feb 20, 2019

/retest

Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@ironcladlou
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, pravisankar, ramr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2019
@openshift-merge-robot openshift-merge-robot merged commit f9e1907 into openshift:release-3.10 Feb 21, 2019
@ramr ramr deleted the v3.10-bugfixes branch February 21, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/network-edge size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants