switch project auth cache to external types #22328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/L
enj
reviewed
Mar 15, 2019
pkg/project/util/util.go
Outdated
| func ConvertProjectToExternal(project *projectapi.Project) *corev1.Namespace { | ||
| externalFinalizers := []corev1.FinalizerName{} | ||
| for _, internalFinalizer := range project.Spec.Finalizers { | ||
| externalFinalizers = append(externalFinalizers, corev1.FinalizerName(string(internalFinalizer))) |
There was a problem hiding this comment.
do you need the internal cast to string ?
pkg/project/util/util.go
Outdated
| Status: kapi.NamespaceStatus{ | ||
| Phase: project.Status.Phase, | ||
| Status: corev1.NamespaceStatus{ | ||
| Phase: corev1.NamespacePhase(string(project.Status.Phase)), |
|
/lgtm Let us hope this still works. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, enj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kube 1.13 removed all internal clients. this must be fixed to even be able to get vendoring tools to load the code in.
/assign @enj
@openshift/sig-auth