Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove internal client dependency from apps server #22330

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@deads2k
Copy link
Contributor

deads2k commented Mar 15, 2019

kube 1.13 removed all internal clients. this must be fixed to even be able to get vendoring tools to load the code in.

/assign @tnozicka
@openshift/sig-master

@tnozicka
Copy link
Contributor

tnozicka left a comment

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Mar 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Mar 18, 2019

https://openshift-gce-devel.appspot.com/pr/22330

green, lgtmd, blocking rebase, merging

@deads2k deads2k merged commit f7ad8ee into openshift:master Mar 18, 2019

2 of 9 checks passed

ci/prow/cmd Job triggered.
Details
ci/prow/e2e-aws Job triggered.
Details
ci/prow/e2e-aws-serial Job triggered.
Details
ci/prow/images Job triggered.
Details
ci/prow/integration Job triggered.
Details
ci/prow/unit Job triggered.
Details
ci/prow/verify Job triggered.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Mar 18, 2019

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-serial 24c4770 link /test e2e-aws-serial
ci/prow/e2e-aws 24c4770 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.