Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch security/apiserver to external client #22334

Merged
merged 1 commit into from Mar 17, 2019

Conversation

Projects
None yet
5 participants
@deads2k
Copy link
Contributor

deads2k commented Mar 15, 2019

kube 1.13 removed all internal clients. this must be fixed to even be able to get vendoring tools to load the code in.

/assign @enj
@openshift/sig-auth

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Mar 16, 2019

/retest

@enj

This comment has been minimized.

Copy link
Member

enj commented Mar 16, 2019

/lgtm
/retest

SCC integration test is still passing so the wiring is still working.

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Mar 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enj

This comment has been minimized.

Copy link
Member

enj commented Mar 17, 2019

/lgtm
/retest

SCC integration test is still passing so the wiring is still working.

@stlaz we really need e2e tests here since it is easy for wiring differences between integration and e2e to invalidate the test.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7f7d78f into openshift:master Mar 17, 2019

9 checks passed

ci/prow/cmd Job succeeded.
Details
ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-serial Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/integration Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
ci/prow/verify Job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.