New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ClusterResourceQuota to CRD #22425
Conversation
812ea3e
to
ae48874
Compare
.../customresourcevalidation/customresourcevalidationregistration/cr_validation_registration.go
Show resolved
Hide resolved
|
/retest |
|
/retest |
9a8916b
to
6578398
Compare
|
/retest |
...o/kubernetes/staging/src/k8s.io/kube-aggregator/pkg/apiserver/always_local_delegate_patch.go
Outdated
Show resolved
Hide resolved
79c1e0b
to
71f9a7b
Compare
|
/retest |
|
unit test is flake EDIT: cmd failed because the CRD was not installed and that caused the new project to fail create because cluster resource quota admission has not synced informer... |
|
@deads2k test-cmd passed ! \o/ |
|
/retest unit test flake |
|
OK, looks like I got 1 green test-cmd pass but it is flaking again. Give the integration test failing on not being able to observe change in status for 30s, I suspect this might be related to either reconciliation controller being slow on updating status or something is messing up the status in storage? |
|
/retest |
1 similar comment
|
/retest |
|
what an adventure. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
https://bugzilla.redhat.com/show_bug.cgi?id=1698538 for TestNewManagerImplStartProbeMode test flake |
|
/retest |
|
@mfojtik might be a failure to build |
|
@deads2k looks more like an infra thing, it happens a lot in unit test job. |
|
/retest |
Goal of this change is to move ClusterResourceQuota from OpenShift API server to CRD so the admission plugins that run in kubernetes apiserver do not have dependency on OpenShift API resource. In case the OpenShift API server have downtime that means every request to Kubernetes API server is delayed.
This PR require openshift/cluster-config-operator#25 to land first, otherwise CRQ is broken.
This will also disable etcd storage for openshift clusterresourcequota so we don't accidentally write to a wrong bucket (and we can actually prove this works).
TODO:
TestIntegration/TestClusterQuotaTestIntegration/TestEtcd3StoragePath/cc @sttts
/cc @deads2k
/cc @enj
/cc @derekwaynecarr