UPSTREAM: 75785: add annotation from namespace controller to indicate… #22429
Conversation
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
the
approved
|
/test all |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
| @@ -295,6 +298,20 @@ func (d *namespacedResourcesDeleter) updateNamespaceStatusFunc(namespace *v1.Nam | |||
| return d.nsClient.UpdateStatus(&newNamespace) | |||
| } | |||
|
|
|||
| // updateSetDeletionFailureFunc will set an annotation indicating that the namespace controller has failed to delete all content | |||
| func (d *namespacedResourcesDeleter) updateSetDeletionFailureFunc(err error) func(namespace *v1.Namespace) (*v1.Namespace, error) { | |||
| errorAnnotationName := "namespace-controller.kube-controller-manager.kubernetes.io/deletion-error" | |||
There was a problem hiding this comment.
before merge, I need to update this to be an alpha something in openshift.io for when the real status pull gets merged upstream
deads2k
force-pushed
the
ns-controller
branch
3 times, most recently
from
8030349
to
dc6dbf8
Compare
… why deletion failed
|
neat /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
makes debugging ns cleanup possible. It's green, needed for debugging other issues. |
|
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
… why deletion failed
/assign @mfojtik