Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add oc command to open the console #23323
This PR adds an experimental command to open the OpenShift console from the CLI. This might be useful enough to add in as actual top-level command (e.g.
It pulls data from the
By default, this URL will be opened in your default web browser. If the
I'm handling specific error message from the API, but I'm not sure on verbiage for them, or if instead of directly handling these use cases, it would be better to just return the err directly.
[APPROVALNOTIFIER] This PR is NOT APPROVED
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Okay, so I think I solved by glide issues:
For example, I created the
I fixed this by commenting out the import statement, running glide, and then uncommenting. This workflow will likely need to be addressed as the staging repo setup is moved forward.
I've rebased this PR based on #23327, but can rebase it once that one is merged.
Talked to @deads2k on Slack about this.
The API server should redirect to the console, if installed. It's not doing that right now. Opened up a BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1730905
As for the "open the URL directly in the browser" pieces, this may be better served by a oc/kubectl plugin. Going to take a look at that separately.
Going to close this PR for now, as there are better ways to do this that don't require cluster-admin or rbac changes.
@cblecker: The following tests failed, say