Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1646886: bump cadvisor #23585

Merged
merged 2 commits into from Aug 16, 2019

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Aug 9, 2019

pull in openshift/google-cadvisor#7

The delta is huge because a make update-deps on a clean origin/master makes a lot of changes. I've split up the bump(*) on the clean master into a separate commit.

Fixes #23492

This is a baseline bump with no change to glide.yaml
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 9, 2019
@openshift-ci-robot
Copy link

@sjenning: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1646886: bump cadvisor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2019
@openshift-ci-robot
Copy link

@sjenning: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1646886: bump cadvisor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

sjenning commented Aug 9, 2019

/retest

1 similar comment
@sjenning
Copy link
Contributor Author

/retest

@mrunalp
Copy link
Member

mrunalp commented Aug 12, 2019

ping @derekwaynecarr

@derekwaynecarr
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [derekwaynecarr,sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@sjenning: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1646886: bump cadvisor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

/test e2e-aws-upgrade

@sjenning
Copy link
Contributor Author

gah, didn't realize that e2e-aws-upgrade normally takes 2h30m to pass and I restarted it 🤦‍♂️

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sjenning
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 19797a6 into openshift:master Aug 16, 2019
@openshift-ci-robot
Copy link

@sjenning: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1646886: bump cadvisor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing network metrics from cadvisor after some time
8 participants