New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1772104: React to openshift/ruby-hello-world update #24143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/lgtm |
@sallyom: This pull request references Bugzilla bug 1772104, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eafca93
to
3283ff8
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sallyom, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3283ff8
to
8166624
Compare
8166624
to
d296edc
Compare
@sallyom you and I are tackling the same issue. I'll cross reference this PR to see if we can get these tests green again. |
@sallyom: This pull request references Bugzilla bug 1772104, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yup I know, there was no easy cherry-pick due to file structure changes, so i created a new commit w/ 3.11, also need to backport to 3.10 for an open security fix PR |
We just merged this one: openshift/jenkins-client-plugin#314 |
I'm closing this, since it's a duplicate of #24112 |
@sallyom: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cc @adambkaplan