Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1772104: React to openshift/ruby-hello-world update #24143

Closed

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Nov 13, 2019

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 13, 2019
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@mfojtik
Copy link
Member

mfojtik commented Nov 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@sallyom sallyom changed the title react to openshift/ruby-hello-world update Bug 1772104: React to openshift/ruby-hello-world update Nov 13, 2019
@openshift-ci-robot
Copy link

@sallyom: This pull request references Bugzilla bug 1772104, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1772104: React to openshift/ruby-hello-world update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 13, 2019
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adambkaplan
Copy link
Contributor

@sallyom you and I are tackling the same issue. I'll cross reference this PR to see if we can get these tests green again.

@openshift-ci-robot
Copy link

@sallyom: This pull request references Bugzilla bug 1772104, which is valid.

In response to this:

Bug 1772104: React to openshift/ruby-hello-world update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sallyom
Copy link
Contributor Author

sallyom commented Nov 14, 2019

you and I are tackling the same issue. I'll cross reference this PR

yup I know, there was no easy cherry-pick due to file structure changes, so i created a new commit w/ 3.11, also need to backport to 3.10 for an open security fix PR

@akram
Copy link
Contributor

akram commented Nov 14, 2019

We just merged this one: openshift/jenkins-client-plugin#314
You also may need it , as this repo is referenced in some e2e tests

@sallyom
Copy link
Contributor Author

sallyom commented Nov 14, 2019

I'm closing this, since it's a duplicate of #24112
@adambkaplan

@openshift-ci-robot
Copy link

@sallyom: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd d296edc link /test cmd
ci/prow/unit d296edc link /test unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sallyom sallyom closed this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants