Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1774352: Update deps to resolve problems between golang.org/x/crypto and golang.org/x/sys #24181

Merged
merged 2 commits into from Nov 21, 2019

Conversation

eparis
Copy link
Member

@eparis eparis commented Nov 20, 2019

golang.org/x/crypto depended on definitions in golang.org/x/sys for s390 but the version of x/sys was quite old.

x/crypto lists a valid version in go.mod requires, but apparently these are ignored by glide.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 20, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2019
@eparis eparis changed the title Update deps to resolve problems between golang.org/x/crypto and golang.org/x/sys Bug 1774352: Update deps to resolve problems between golang.org/x/crypto and golang.org/x/sys Nov 20, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 20, 2019
@openshift-ci-robot
Copy link

@eparis: This pull request references Bugzilla bug 1774352, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1774352: Update deps to resolve problems between golang.org/x/crypto and golang.org/x/sys

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Nov 20, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, eparis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@eparis: This pull request references Bugzilla bug 1774352, which is valid.

In response to this:

Bug 1774352: Update deps to resolve problems between golang.org/x/crypto and golang.org/x/sys

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis
Copy link
Member Author

eparis commented Nov 20, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4605373 into openshift:master Nov 21, 2019
@openshift-ci-robot
Copy link

@eparis: All pull requests linked via external trackers have merged. Bugzilla bug 1774352 has been moved to the MODIFIED state.

In response to this:

Bug 1774352: Update deps to resolve problems between golang.org/x/crypto and golang.org/x/sys

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants