Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1775826: [release-4.3] UPSTREAM: drop 83592: added --reserved-cpus kubelet command option #24224

Merged

Conversation

vladikr
Copy link
Member

@vladikr vladikr commented Nov 26, 2019

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 26, 2019
@openshift-ci-robot
Copy link

Hi @vladikr. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 26, 2019
@vladikr vladikr changed the base branch from master to release-4.3 November 26, 2019 19:14
@openshift-ci-robot
Copy link

@vladikr: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.3] UPSTREAM: drop 83592: added --reserved-cpus kubelet command option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 26, 2019
@vladikr vladikr changed the title [release-4.3] UPSTREAM: drop 83592: added --reserved-cpus kubelet command option [release-4.3] UPSTREAM: drop 83592: added --reserved-cpus kubelet command option - Bug 1775826 Nov 27, 2019
@openshift-ci-robot
Copy link

@vladikr: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.3] UPSTREAM: drop 83592: added --reserved-cpus kubelet command option - Bug 1775826

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vladikr
Copy link
Member Author

vladikr commented Nov 27, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

@vladikr: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vladikr vladikr changed the title [release-4.3] UPSTREAM: drop 83592: added --reserved-cpus kubelet command option - Bug 1775826 Bug 1775826: [release-4.3] UPSTREAM: drop 83592: added --reserved-cpus kubelet command option Nov 27, 2019
@openshift-ci-robot
Copy link

@vladikr: This pull request references Bugzilla bug 1775826, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1775826: [release-4.3] UPSTREAM: drop 83592: added --reserved-cpus kubelet command option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 27, 2019
@eparis
Copy link
Member

eparis commented Nov 27, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2019
@eparis
Copy link
Member

eparis commented Nov 27, 2019

/retest

@vladikr
Copy link
Member Author

vladikr commented Nov 28, 2019

/test e2e-cmd

@vladikr
Copy link
Member Author

vladikr commented Nov 28, 2019

/retest

@vladikr
Copy link
Member Author

vladikr commented Nov 28, 2019

/test e2e-aws-serial

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019
@sjenning
Copy link
Contributor

sjenning commented Dec 2, 2019

/cc @derekwaynecarr

@rphillips
Copy link
Contributor

rphillips commented Dec 2, 2019

/lgtm cancel

this should be applied to master first, and then backported. But since this is a new feature, we will pick this up with the 1.17 rebase.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019
@sjenning
Copy link
Contributor

sjenning commented Dec 2, 2019

this is really backporting a feature. we typically do not do this. features that go in upstream come into origin via rebasing typically. is there an exception in this case?

@vladikr
Copy link
Member Author

vladikr commented Dec 2, 2019

this is really backporting a feature. we typically do not do this. features that go in upstream come into origin via rebasing typically. is there an exception in this case?

@sjenning Yes, this feature is needed in 4.3 as per the bz. Perhaps, @eparis could provide the justification?

@vladikr
Copy link
Member Author

vladikr commented Dec 2, 2019

this should be applied to master first, and then backported. But since this is a new feature, we will pick this up with the 1.17 rebase.

@rphillips Yes, I wasn't sure about the process. I only knew that kubernetes/kubernetes#83592
was merged upstream and thought it should already appear in master.

What is the right course of action should be?

@derekwaynecarr
Copy link
Member

Is this actually settable without a corresponding bump of the machine config operator?

@vladikr
Copy link
Member Author

vladikr commented Dec 2, 2019

Is this actually settable without a corresponding bump of the machine config operator?

Yes, if you manually set it in kubelet.conf or hyperkube manually. However, MCO will require an update, to include the schema to be able to set reservedSystemCPUs.

I'm not sure where do I need to make this change in MCO, but I thought to take care of this backport first.

@derekwaynecarr
Copy link
Member

required for isolcpu integration.

/approve

@derekwaynecarr
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, vladikr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@vladikr
Copy link
Member Author

vladikr commented Dec 3, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit bbbcdfb into openshift:release-4.3 Dec 3, 2019
@openshift-ci-robot
Copy link

@vladikr: All pull requests linked via external trackers have merged. Bugzilla bug 1775826 has been moved to the MODIFIED state.

In response to this:

Bug 1775826: [release-4.3] UPSTREAM: drop 83592: added --reserved-cpus kubelet command option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants