New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1775826: [release-4.3] UPSTREAM: drop 83592: added --reserved-cpus kubelet command option #24224
Bug 1775826: [release-4.3] UPSTREAM: drop 83592: added --reserved-cpus kubelet command option #24224
Conversation
Hi @vladikr. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vladikr: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vladikr: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@vladikr: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vladikr: This pull request references Bugzilla bug 1775826, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
b5923ca
to
a8376d7
Compare
/test e2e-cmd |
/retest |
/test e2e-aws-serial |
/lgtm |
/cc @derekwaynecarr |
/lgtm cancel this should be applied to master first, and then backported. But since this is a new feature, we will pick this up with the 1.17 rebase. |
this is really backporting a feature. we typically do not do this. features that go in upstream come into origin via rebasing typically. is there an exception in this case? |
@rphillips Yes, I wasn't sure about the process. I only knew that kubernetes/kubernetes#83592 What is the right course of action should be? |
Is this actually settable without a corresponding bump of the machine config operator? |
Yes, if you manually set it in kubelet.conf or hyperkube manually. However, MCO will require an update, to include the schema to be able to set reservedSystemCPUs. I'm not sure where do I need to make this change in MCO, but I thought to take care of this backport first. |
required for isolcpu integration. /approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, vladikr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@vladikr: All pull requests linked via external trackers have merged. Bugzilla bug 1775826 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Backport of kubernetes/kubernetes#83592