Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1793205: Fix typo in type registration for externalipranger. #24390

Closed
wants to merge 2 commits into from
Closed

Bug 1793205: Fix typo in type registration for externalipranger. #24390

wants to merge 2 commits into from

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Jan 13, 2020

No description provided.

@openshift-ci-robot
Copy link

@abhat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix typo in type registration for externalipranger.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2020
@abhat abhat changed the title Fix typo in type registration for externalipranger. Bug 1751840: Fix typo in type registration for externalipranger. Jan 13, 2020
@abhat
Copy link
Contributor Author

abhat commented Jan 13, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 13, 2020
@openshift-ci-robot
Copy link

@abhat: This pull request references Bugzilla bug 1751840, which is invalid:

  • expected dependent Bugzilla bug 1759182 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat abhat changed the title Bug 1751840: Fix typo in type registration for externalipranger. Bug 1759182: Fix typo in type registration for externalipranger. Jan 13, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 13, 2020
@openshift-ci-robot
Copy link

@abhat: This pull request references Bugzilla bug 1759182, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1759182: Fix typo in type registration for externalipranger.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 13, 2020
@abhat
Copy link
Contributor Author

abhat commented Jan 13, 2020

/bugzilla refresh

@abhat
Copy link
Contributor Author

abhat commented Jan 14, 2020

/test e2e-aws
/test e2e-aws-serial

@abhat
Copy link
Contributor Author

abhat commented Jan 15, 2020

/test e2e-aws

@abhat
Copy link
Contributor Author

abhat commented Jan 15, 2020

/unassign @squeed
/assign @danwinship

@abhat abhat requested review from deads2k and removed request for squeed January 15, 2020 01:10
@danwinship
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 15, 2020
@danwinship danwinship mentioned this pull request Jan 15, 2020
Closed
@knobunc
Copy link
Contributor

knobunc commented Jan 20, 2020

/approve

knobunc
knobunc approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, danwinship, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhat
Copy link
Contributor Author

abhat commented Jan 20, 2020

This typo is present in 4.2 and 4.3 as well. I will create a separate bug to track those fixes first before we backport this.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020
@abhat abhat changed the title Bug 1759182: Fix typo in type registration for externalipranger. Bug 1793205: Fix typo in type registration for externalipranger. Jan 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 21, 2020
@openshift-ci-robot
Copy link

@abhat: This pull request references Bugzilla bug 1793205, which is invalid:

  • expected dependent Bugzilla bug 1793199 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1793204 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1793638 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1793205: Fix typo in type registration for externalipranger.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor Author

abhat commented Jan 21, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@abhat: This pull request references Bugzilla bug 1793205, which is invalid:

  • expected dependent Bugzilla bug 1793199 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1793204 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1793638 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2020
@abhat
Copy link
Contributor Author

abhat commented Jan 22, 2020

/test cmd

@abhat
Copy link
Contributor Author

abhat commented Jan 23, 2020

/retest

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2020
@abhat
Copy link
Contributor Author

abhat commented Jan 23, 2020

/test cmd
/test e2e-aws-serial
/test integration

@abhat
Copy link
Contributor Author

abhat commented Jan 24, 2020

/test cmd

@sdodson
Copy link
Member

sdodson commented Mar 26, 2020

/close
wontfix in 4.1

@openshift-ci-robot
Copy link

@sdodson: Closed this PR.

In response to this:

/close
wontfix in 4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@danwinship danwinship

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abhat @openshift-ci-robot @danwinship @knobunc @sdodson